Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9534: Add NodeRelation to SavedQuery Export #9794

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Fix #9534: Add NodeRelation to SavedQuery Export #9794

merged 6 commits into from
Apr 19, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Mar 22, 2024

resolves #9534

Problem

For export configs:

  1. schema_name should default to project schema if not set in config
  2. database should be set to project database

Solution

Run export nodes through the update_parsed_node_relation_names function.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (7e72cac) to head (02a545c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9794      +/-   ##
==========================================
+ Coverage   88.05%   88.08%   +0.02%     
==========================================
  Files         178      178              
  Lines       22544    22556      +12     
==========================================
+ Hits        19852    19868      +16     
+ Misses       2692     2688       -4     
Flag Coverage Δ
integration 85.40% <100.00%> (+0.02%) ⬆️
unit 62.00% <26.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke changed the title Fix #9534: Add NodeRelation to SavedQuery Fix #9534: Add NodeRelation to SavedQuery Export Apr 9, 2024
@aranke aranke added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Apr 10, 2024
@aranke aranke marked this pull request as ready for review April 10, 2024 17:32
@aranke aranke requested a review from a team as a code owner April 10, 2024 17:32
@aranke aranke requested a review from QMalcolm April 10, 2024 17:33
@DevonFulcher DevonFulcher self-requested a review April 10, 2024 17:41
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's get it merged in.

As a side note, wow is update_parsed_node_relation_names is a doozy of a function. Hopefully we can find some segment of work in the future to make how that function operates easier to follow.

@aranke aranke merged commit 4811ada into main Apr 19, 2024
62 checks passed
@aranke aranke deleted the fix_9534 branch April 19, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved queries should always include relation spec (database.schema.alias), and respect generate_x_name macros
2 participants