-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9534: Add NodeRelation to SavedQuery Export #9794
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9794 +/- ##
==========================================
+ Coverage 88.05% 88.08% +0.02%
==========================================
Files 178 178
Lines 22544 22556 +12
==========================================
+ Hits 19852 19868 +16
+ Misses 2692 2688 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Let's get it merged in.
As a side note, wow is update_parsed_node_relation_names
is a doozy of a function. Hopefully we can find some segment of work in the future to make how that function operates easier to follow.
resolves #9534
Problem
For export configs:
schema_name
should default to project schema if not set in configdatabase
should be set to project databaseSolution
Run
export
nodes through the update_parsed_node_relation_names function.Checklist