move cache exceptions to dbt/adapters #9361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9361 +/- ##
=======================================
Coverage 86.61% 86.61%
=======================================
Files 225 225
Lines 27024 27025 +1
=======================================
+ Hits 23406 23407 +1
Misses 3618 3618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5 tasks
MichelleArk
requested review from
mikealfare
and removed request for
martynydbt
mikealfare
approved these changes
Jan 10, 2024
emmyoop
pushed a commit
that referenced
this pull request
Jan 12, 2024
emmyoop
pushed a commit
that referenced
this pull request
Jan 12, 2024
emmyoop
added a commit
that referenced
this pull request
Jan 16, 2024
* replace dbt/common with dbt-common * update requirements, remove colorama * remove dbt-common unit tests * WIP * some cleanup * update imports from dbt.common to dbt_common * remove tests/unit/common * changelog entry * remove commented out code * move cache exceptions to dbt/adapters (#9361) * point to dbt-common main * Move the contents of dbt.contracts.results to a new dbt.artifacts directory (#9350) * conflict resolution cleanup * cleanup * add ignoreb --------- Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Gerda Shank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9362
Problem
As pointed out in dbt-labs/dbt-common#13 (comment), cache-related exceptions are an adapters concern and would be better suited in dbt/adapters than dbt/common
Solution
Move cache exceptions to dbt/adapters + update import paths
Checklist