Rename config block test -> data-tests #9072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michelle Ark <[email protected]>
* WIP * remove breakpoint * fix tests, fix schema
* use unit test name as top level * remove breakpoints * finish converting tests * fix unit test node name * breakpoints * fix partial parsing bug * comment out duplicate test * fix test and make unique id match other uniqu id patterns * clean up * fix incremental test * Update tests/functional/unit_testing/test_unit_testing.py
* WIP * adding tests * fix tests * more tests * fix broken tests * fix broken tests * change to csv extension * fix unit test yaml * add mixed inline and file csv test * add mixed inline and file csv test * additional changes * read file directly * some cleanup and soem test fixes - wip * fix test * use better file searching * fix final test * cleanup * use absolute path and fix tests
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
force-pushed
the
er/8699-config-block-names
branch
from
82eaaf8 to
1a908b6
Compare
* Add unit tests to state:modified selection * Get defer working too yolo * Refactor per marky suggestion * Add changelog * separate out unit test state tests + fix csv fixture tests * formatting * detect changes to fixture files with state:modified --------- Co-authored-by: Michelle Ark <[email protected]>
…fied in YAML config (#9064) Co-authored-by: Michelle Ark <[email protected]> Fix #8652: Use seed value if rows not specified
…-core into unit_testing_feature_branch
* Switch to using 'test' command instead of 'unit-test' * Remove old unit test * Put daff changes into task/test.py * changie * test_type:unit * Add unit test to build and make test * Select test_type:data * Add unit tets to test_graph_selector_methods.py * Fix fqn to incude path components * Update build test * Remove part of message in test_csv_fixtures.py that's different on Windows * Rename build test directory
…olete dprecations
emmyoop
force-pushed
the
er/8699-config-block-names
branch
from
29bda75 to
32f9ada
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## unit_testing_feature_branch #9072 +/- ##
===============================================================
- Coverage 86.85% 79.53% -7.33%
===============================================================
Files 180 180
Lines 27083 27122 +39
===============================================================
- Hits 23524 21571 -1953
- Misses 3559 5551 +1992
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gshank
force-pushed
the
unit_testing_feature_branch
branch
2 times, most recently
from
8fbbb65 to
56dfb34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8699
Problem
Tests is a confusing config block name with unit-tests in the mix now.
Solution
Support
data-testsas thetestsconfig while still allowingtests, but deprecate it.Checklist