Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove guild as codeowner #8778

Merged
merged 1 commit into from
Oct 5, 2023
Merged

remove guild as codeowner #8778

merged 1 commit into from
Oct 5, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 5, 2023

Problem

CODEOWNERS contains the guild as a code owner but it's no longer relevant

Solution

Remove the oss guild from the file

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Oct 5, 2023
@emmyoop emmyoop requested a review from a team as a code owner October 5, 2023 13:10
@emmyoop emmyoop requested review from aranke and VersusFacit and removed request for a team October 5, 2023 13:10
@cla-bot cla-bot bot added the cla:yes label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c6ff3ab) 86.50% compared to head (cb72a83) 86.50%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8778   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files         176      176           
  Lines       25821    25821           
=======================================
  Hits        22337    22337           
  Misses       3484     3484           
Flag Coverage Δ
integration 83.27% <ø> (ø)
unit 65.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop merged commit 0c85e61 into main Oct 5, 2023
60 checks passed
@emmyoop emmyoop deleted the er/update-codeowners branch October 5, 2023 15:16
QMalcolm pushed a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants