-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support doc blocks on versioned models #8771
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8771 +/- ##
==========================================
+ Coverage 86.50% 86.55% +0.04%
==========================================
Files 176 176
Lines 25825 25823 -2
==========================================
+ Hits 22341 22351 +10
+ Misses 3484 3472 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(cherry picked from commit df791f7)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-8771-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df791f729cf3ba9d882ea168894cc4318b7193b6
# Push it to GitHub
git push --set-upstream origin backport-8771-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
(cherry picked from commit df791f7)
* support doc blocks (#8771) (cherry picked from commit df791f7) * pin dev requirement --------- Co-authored-by: Emily Rockman <[email protected]>
resolves #8540
Problem
Column descriptions on versioned models error out when using doc blocks
Solution
Support doc blocks for versioned columns
Checklist