Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support doc blocks on versioned models #8771

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 4, 2023

resolves #8540

Problem

Column descriptions on versioned models error out when using doc blocks

Solution

Support doc blocks for versioned columns

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner October 4, 2023 19:43
@emmyoop emmyoop requested a review from aranke October 4, 2023 19:43
@cla-bot cla-bot bot added the cla:yes label Oct 4, 2023
@emmyoop emmyoop changed the title support doc blocks support doc blocks on versioned models Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eac13e3) 86.50% compared to head (bd7a7da) 86.55%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8771      +/-   ##
==========================================
+ Coverage   86.50%   86.55%   +0.04%     
==========================================
  Files         176      176              
  Lines       25825    25823       -2     
==========================================
+ Hits        22341    22351      +10     
+ Misses       3484     3472      -12     
Flag Coverage Δ
integration 83.39% <100.00%> (+0.11%) ⬆️
unit 65.12% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/parser/manifest.py 92.24% <ø> (ø)
core/dbt/parser/schema_renderer.py 95.23% <100.00%> (+0.23%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit df791f7 into main Oct 5, 2023
55 checks passed
@emmyoop emmyoop deleted the er/8540-model-version-doc-blocks branch October 5, 2023 13:12
github-actions bot pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit df791f7)
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-8771-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df791f729cf3ba9d882ea168894cc4318b7193b6
# Push it to GitHub
git push --set-upstream origin backport-8771-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-8771-to-1.5.latest.

emmyoop added a commit that referenced this pull request Oct 5, 2023
emmyoop added a commit that referenced this pull request Oct 6, 2023
(cherry picked from commit df791f7)
QMalcolm pushed a commit that referenced this pull request Oct 9, 2023
emmyoop added a commit that referenced this pull request Oct 10, 2023
emmyoop added a commit that referenced this pull request Oct 10, 2023
* support doc blocks (#8771)

(cherry picked from commit df791f7)

* pin dev requirement

---------

Co-authored-by: Emily Rockman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3067] [Bug] Docs blocks don't work in model versions
2 participants