Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild manifest missed fields #8755

Merged
merged 2 commits into from
Oct 2, 2023
Merged

rebuild manifest missed fields #8755

merged 2 commits into from
Oct 2, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 30, 2023

missing from PRs #8700 & #8646

Problem

Fields were added but the manifest was not regenerated.

Solution

Regenerate v11 of the manifest to add missing fields

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Sep 30, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop requested a review from QMalcolm September 30, 2023 01:11
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c4f09b1) 86.50% compared to head (f4bd0cd) 86.55%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8755      +/-   ##
==========================================
+ Coverage   86.50%   86.55%   +0.04%     
==========================================
  Files         176      176              
  Lines       25804    25820      +16     
==========================================
+ Hits        22323    22348      +25     
+ Misses       3481     3472       -9     
Flag Coverage Δ
integration 83.39% <ø> (+0.11%) ⬆️
unit 65.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review October 2, 2023 12:02
@emmyoop emmyoop requested review from a team as code owners October 2, 2023 12:02
@emmyoop emmyoop requested review from wpowers-dbt and removed request for a team October 2, 2023 12:02
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit 46ee3f3 into main Oct 2, 2023
55 checks passed
@emmyoop emmyoop deleted the er/catchup-manifest branch October 2, 2023 14:38
QMalcolm pushed a commit that referenced this pull request Oct 9, 2023
* rebuild manifest missed fields

* changelogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants