-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag:
selection for projects with semantic models
#8750
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tag:
selection for semantic modelstag:
selection for projects with semantic models
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8750 +/- ##
==========================================
- Coverage 86.62% 84.11% -2.51%
==========================================
Files 176 176
Lines 25772 25772
==========================================
- Hits 22325 21679 -646
- Misses 3447 4093 +646
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great 🚀 I double checked that without the fix in selector_methods.py
the added test failed, and it did. Then it stopped failing once the fix in selector_methods.py
was present. WOOOOOOOO
* Add unit test to repro regression * Add defensive code for tag: selection * Add changelog entry (cherry picked from commit 48c97e8) Co-authored-by: Jeremy Cohen <[email protected]>
resolves #8749
Problem
In projects with semantic models,
tag:
selection started failing with the release of v1.6.4Solution
Add more defensive code around
tag:
selection. Previously, this method assumed that all graph-selectable resources have atags
attribute, but semantic models do not (yet).Rather than backporting an addition of
tags
to semantic models, we would rather backport more defensive code.Checklist