Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8509: Support doc blocks in nested semantic model YAML #8709

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

aranke
Copy link
Member

@aranke aranke commented Sep 25, 2023

resolves #8509

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@aranke aranke requested a review from a team as a code owner September 25, 2023 23:13
@aranke aranke requested a review from MichelleArk September 25, 2023 23:13
@cla-bot cla-bot bot added the cla:yes label Sep 25, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke requested review from QMalcolm and gshank and removed request for MichelleArk September 25, 2023 23:14
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (aa86fdf) 86.61% compared to head (eb253b4) 85.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8709      +/-   ##
==========================================
- Coverage   86.61%   85.30%   -1.31%     
==========================================
  Files         176      176              
  Lines       25678    25695      +17     
==========================================
- Hits        22240    21919     -321     
- Misses       3438     3776     +338     
Flag Coverage Δ
integration 81.66% <70.58%> (-1.70%) ⬇️
unit 65.12% <11.76%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/parser/schema_renderer.py 95.00% <ø> (ø)
core/dbt/parser/manifest.py 87.42% <70.58%> (-4.66%) ⬇️

... and 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aranke aranke merged commit d4fe9a8 into main Sep 26, 2023
50 checks passed
@aranke aranke deleted the fix_8509 branch September 26, 2023 15:02
@github-actions
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-8709-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4fe9a8ad4cbef39054266c26ceeea2d2527e330
# Push it to GitHub
git push --set-upstream origin backport-8709-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-8709-to-1.6.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3041] [Bug] Semantic Model nested element descriptions do not support doc blocks
3 participants