Add semantic model test to test_contracts_graph_parsed.py
#8654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests in `test_contracts_graph_parsed.py` are meant to ensure that we can go from objects to dictionaries and back without any changes. We've had a desire to simplify these tests. Most tests in this file have three to four fixtures, this test only has one. What a test of this format ensures is that parsing a SemanticModel from a dictionary doesn't add/drop any keys from the dictionary and that when going back to the dictionary no keys are dropped. This style of test will still break whenever the semantic model (or sub objects) change. However now when that happens, only one fixture will have to be updated (whereas previously we had to update 3-4 fixtures).
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8654 +/- ##
==========================================
- Coverage 86.60% 86.50% -0.10%
==========================================
Files 175 176 +1
Lines 25638 25856 +218
==========================================
+ Hits 22204 22368 +164
- Misses 3434 3488 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hypothesis is a python package for doing property testing. The `@given` parameterizes a test, with it generating the arguements it has following `strategies`. The main strategies we use is `builds` this takes in a callable passes any sub strategies for named arguements, and will try to infer any other arguments if the callable is typed. I found that even though the test was run many many times, some of the `SemanticModel` properties weren't being changed. For instance `dimensions`, `entities`, and `measures` were always empty lists. Because of this I defined sub strategies for some attributes of `SemanticModel`s.
emmyoop
requested changes
Oct 4, 2023
gshank
approved these changes
Oct 6, 2023
martynydbt
deleted the
qmalcolm--8139-test-semantic-model-graph-contract
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8139
Problem
The tests in
test_contracts_graph_parsed.pyare meant to ensure that we can go from objects to dictionaries and back without any changes. There are two problems this PR aims to solveSolution
We added a test for semantic models symmetry. The test depends on a new package
hypothesis. The@givenparameterizes a test, with it generating the arguements it has followingstrategies. The main strategies we use isbuildsthis takes in a callable passes any sub strategies for named arguements, and will try to infer any other arguments if the callable is typed. I found that even though the test was run many many times, some of theSemanticModelproperties weren't being changed. For instancedimensions,entities, andmeasureswere always empty lists. Because of this I defined sub strategies for some attributes ofSemanticModels.Checklist