Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type aliasing for model contract column data_type #8592
Type aliasing for model contract column data_type #8592
Changes from 17 commits
436010e
f05acd1
a593b13
20032d8
9ac3375
396838f
9e9bc5a
cc86526
7ecac7f
d0e46af
c42f2f5
053c1e1
f9ed1fa
9772598
118d8a6
2fe0382
a44648d
1544c10
4084fc4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1234 in core/dbt/context/providers.py
Codecov / codecov/patch
core/dbt/context/providers.py#L1234
Check warning on line 1243 in core/dbt/context/providers.py
Codecov / codecov/patch
core/dbt/context/providers.py#L1242-L1243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the
translate_type
function fails? Can we do this instead?Also, can we add a test for this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base "translate_type" function return the passed in type if no translation exists. If the adapter hasn't implemented a different translate_type function it would use the base one.
Check warning on line 1246 in core/dbt/context/providers.py
Codecov / codecov/patch
core/dbt/context/providers.py#L1245-L1246