Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8544: Parse the correct schema version from manifest #8551

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Conversation

aranke
Copy link
Member

@aranke aranke commented Sep 5, 2023

resolves #8544
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (9aff3ca) 86.39% compared to head (b8d3367) 86.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8551      +/-   ##
==========================================
+ Coverage   86.39%   86.41%   +0.01%     
==========================================
  Files         174      174              
  Lines       25587    25587              
==========================================
+ Hits        22106    22111       +5     
+ Misses       3481     3476       -5     
Flag Coverage Δ
integration 83.22% <100.00%> (+0.01%) ⬆️
unit 65.04% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/contracts/graph/manifest.py 93.84% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke changed the title Fix #8544: Don't drop metrics data during state comparison Fix #8544: Parse the correct schema version from manifest Sep 6, 2023
@aranke aranke marked this pull request as ready for review September 6, 2023 15:23
@aranke aranke requested a review from a team as a code owner September 6, 2023 15:23
@aranke aranke requested a review from ChenyuLInx September 6, 2023 15:23
@aranke aranke requested review from emmyoop and QMalcolm September 6, 2023 15:25
@aranke aranke merged commit d66fe21 into main Sep 6, 2023
@aranke aranke deleted the fix_8544 branch September 6, 2023 19:38
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-8551-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d66fe214d9ed42743f7d05c66195c8dd5db3a7d2
# Push it to GitHub
git push --set-upstream origin backport-8551-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-8551-to-1.6.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3071] [Bug] failed to resolve schema version
3 participants