Fix test_builtin_invocation_args_dict_function #6898
Conversation
…f github.com:dbt-labs/dbt-core into jerco/fix-test_builtin_invocation_args_dict_function
| anonymous_usage_stats = click.option( | ||
| "--anonymous-usage-stats/--no-anonymous-usage-stats", | ||
| envvar="DBT_ANONYMOUS_USAGE_STATS", | ||
| # TODO: Rename this to meet naming conventions (the word "send" is redundant) |
There was a problem hiding this comment.
👍 Tracking this in #6903
There was a problem hiding this comment.
Yeah, it turns out renaming a symbol in some places and not others is confusing AF. Might as well do it all at once since it's going to require changes in a medium sized pile of tests that have a manually set value for send stats (not sure why, most of them have nothing to do with tracking).
/shrug
| @@ -45,25 +45,54 @@ def test_log_path_default(self, run_context): | |||
| assert getattr(flags, "LOG_PATH") == "logs" | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "do_not_track,expected_anonymous_usage_stats", | |||
| "set_stats_param,do_not_track,expected_anonymous_usage_stats", | |||
There was a problem hiding this comment.
@MichelleArk
Hilariously the tests were still passing because they were just testing that DO_NOT_TRACK was honored but since boolean logic is easy to get wrong, especially when renaming things I expanded the test matrix a bit. :)
There was a problem hiding this comment.
Thank you!! Looks great.
| @@ -61,7 +64,11 @@ def parse_json_logs(json_log_output): | |||
|
|
|||
| def find_result_in_parsed_logs(parsed_logs, result_name): | |||
| return next( | |||
There was a problem hiding this comment.
Nit: Can we rewrite this as a loop instead?
iknox-fa
deleted the
jerco/fix-test_builtin_invocation_args_dict_function
branch
resolves [no issue]
Description
Fix
test_builtin_invocation_args_dict_function. There are a few changes in v1.5 (all reasonable) that we'll want to clearly call out for end users. I'll leave comments below.Checklist
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PRI have runchangie newto create a changelog entry