copy over windows compat logic for colored log output #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this change as is, and it definitely doesn't work. |
|
this didn't work either, but we should probably still use the same colorama setup. |
|
To address the previous comments, those commits were attempts to solve #4443 that failed. However, this PR is still open because I think it's valuable to include the windows color setup that was included in the legacy logger. |
nathaniel-may
changed the title
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
automatic commit by git-black, original commits: 6fae647
This was referenced Feb 25, 2022
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I originally added this PR to try and solve compatibility issues for shells not displaying color in #4443 , but it turns out those are at the shell level (not system) which is inaccessible to Colorama. While exploring that, it looks like we didn't copy over the existing Colorama windows compatibility logic from the old logging module, so this PR puts that back in place.
Checklist
CHANGELOG.mdand added information about my change