Events with graph_func include actual output of graph_func #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The log output with the mypy workaround looks like: 16:14:54 | [ debug ] | before rename: <bound method RelationsCache.dump_graph of <dbt.adapters.cache.RelationsCache object at 0x10f298850>> |
nathaniel-may
approved these changes
Nov 29, 2021
gshank
force-pushed
the
graph_dump_events
branch
from
888a59f to
87317d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4260
Description
There are a handful of event classes that use a graph_func which are not actually logging the output of the function. There was a workaround for a mypy bug, but it doesn't seem to have been actually working.
Checklist
CHANGELOG.mdand added information about my change