Provide function to set the invocation_id #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
approved these changes
Nov 29, 2021
| @@ -324,3 +324,10 @@ def get_invocation_id() -> str: | |||
| if invocation_id is None: | |||
| invocation_id = str(uuid.uuid4()) | |||
| return invocation_id | |||
|
|
|||
|
|
|||
| def set_invocation_id() -> None: | |||
There was a problem hiding this comment.
Would it be useful to have it return the invocation id instead of None?
There was a problem hiding this comment.
I thought about that, but the way it's used, not really. Other code gets the current invocation_id from the 'get_invocation_id' function, and that will stay the same, so we're just changing it in the spawned copy of the code for the places where get_invocation_id is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4337
Description
This adds a 'set_invocation_id' function for use of the dbt rpc server.
Checklist
CHANGELOG.mdand added information about my change