Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fix #11000 #11001: Add doc_blocks to manifest for nodes and columns #11224

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aranke
Copy link
Member

@aranke aranke commented Jan 21, 2025

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jan 21, 2025
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (31881d2) to head (d2cbb68).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11224      +/-   ##
==========================================
- Coverage   88.92%   84.70%   -4.22%     
==========================================
  Files         187      187              
  Lines       24049    24070      +21     
==========================================
- Hits        21386    20389     -997     
- Misses       2663     3681    +1018     
Flag Coverage Δ
integration 84.70% <96.87%> (-1.61%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 84.70% <96.87%> (-4.22%) ⬇️
Integration Tests 84.70% <96.87%> (-1.61%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add docs to depends_on for nodes in manifest.json
1 participant