Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml snapshot specification with data tests #11156

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Dec 16, 2024

Resolves #11110

Problem

We were writing the compiled version of the snapshot node to the yaml file name, so that when generic tests were written out the "directory" was a file. In addition multiple snapshots nodes would have been written to the same output file.

Solution

Construct the yaml snapshot compiled path including the "name" + ".sql" of the snapshot node.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner December 16, 2024 20:30
@cla-bot cla-bot bot added the cla:yes label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (7df04b0) to head (2b1e4c1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11156      +/-   ##
==========================================
- Coverage   88.92%   88.88%   -0.04%     
==========================================
  Files         187      187              
  Lines       23974    24003      +29     
==========================================
+ Hits        21318    21335      +17     
- Misses       2656     2668      +12     
Flag Coverage Δ
integration 86.19% <100.00%> (-0.11%) ⬇️
unit 61.99% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 61.99% <50.00%> (+0.01%) ⬆️
Integration Tests 86.19% <100.00%> (-0.11%) ⬇️

@gshank gshank merged commit 6076cf7 into main Dec 18, 2024
61 of 63 checks passed
@gshank gshank deleted the yaml_snapshot_tests branch December 18, 2024 19:24
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
gshank added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants