add allow additional property for Model and SourceDefinition #11138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuLInx
added
the
artifact_minor_upgrade
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11138 +/- ##
==========================================
- Coverage 88.89% 88.85% -0.05%
==========================================
Files 187 187
Lines 23974 23978 +4
==========================================
- Hits 21312 21305 -7
- Misses 2662 2673 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ChenyuLInx
commented
Dec 12, 2024
| @@ -9121,19 +9133,7 @@ | |||
| "type": "integer" | |||
| }, | |||
| "granularity": { | |||
| "enum": [ | |||
There was a problem hiding this comment.
Not sure why this gets changed
There was a problem hiding this comment.
I checked out main branch and generated a schema, these changes are also there, so it is not particular to this PR
ChenyuLInx
commented
Dec 12, 2024
| @@ -372,6 +372,7 @@ def expected_seeded_manifest(project, model_database=None, quote_model=False): | |||
| "version": None, | |||
| "latest_version": None, | |||
| "time_spine": None, | |||
| "batch": None, | |||
There was a problem hiding this comment.
I am not sure why I would have to add this field in expected manifest
ChenyuLInx
commented
Dec 12, 2024
| @@ -503,6 +503,8 @@ def verify_manifest(project, expected_manifest, start_time, manifest_schema_path | |||
| elif key in ["nodes", "sources", "exposures", "metrics", "disabled", "docs"]: | |||
| for unique_id, node in expected_manifest[key].items(): | |||
| assert unique_id in manifest[key] | |||
| if "_event_status" in manifest[key][unique_id]: | |||
There was a problem hiding this comment.
Not sure why _event_status starts to pop up
ChenyuLInx
force-pushed
the
cl/allow_additional_property_for_model_and_source
branch
3 times, most recently
from
0f762b9 to
13acd66
Compare
ChenyuLInx
commented
Dec 12, 2024
gshank
approved these changes
Dec 12, 2024
ChenyuLInx
commented
Dec 12, 2024
ChenyuLInx
force-pushed
the
cl/allow_additional_property_for_model_and_source
branch
from
26f80b7 to
7acd049
Compare
ChenyuLInx
commented
Dec 12, 2024
| @@ -51,4 +52,10 @@ def __post_serialize__(self, dct: Dict, context: Optional[Dict] = None): | |||
| dct = super().__post_serialize__(dct, context) | |||
| if context and context.get("artifact") and "defer_relation" in dct: | |||
| del dct["defer_relation"] | |||
|
|
|||
| # delete extra keys that should't be serialized | |||
There was a problem hiding this comment.
Ohhhhhhhhh that makes sense. Thank you for figuring this out and removing it with the below process 👍
ChenyuLInx
commented
Dec 13, 2024
MichelleArk
reviewed
Dec 13, 2024
MichelleArk
reviewed
Dec 13, 2024
MichelleArk
reviewed
Dec 13, 2024
ChenyuLInx
force-pushed
the
cl/allow_additional_property_for_model_and_source
branch
from
f800044 to
fda1eb9
Compare
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
added
Skip Changelog
MichelleArk
reviewed
Dec 13, 2024
| # that are not present in the schema, from_dict will work fine. | ||
| # As long as validate is not called, the schema will not be enforced. | ||
| # This is intentional, as it allows for safer schema upgrades. | ||
| raise RuntimeError( |
There was a problem hiding this comment.
This should probably be a dbtInternalError
MichelleArk
approved these changes
Dec 13, 2024
ChenyuLInx
deleted the
cl/allow_additional_property_for_model_and_source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing additional properties on Model and SourceDefinition so we are more forgiving at reading artifacts.
This change doesn't change user contract. User still cannot add additional fields to project freely
Checklist