Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --empty option for 'snapshot' command #10962

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Support --empty option for 'snapshot' command #10962

merged 2 commits into from
Nov 1, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 31, 2024

Resolves #10372

Problem

The empty flag is not allowed for snapshots.

Solution

Add 'empty' to the permitted option flags.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner October 31, 2024 20:36
@cla-bot cla-bot bot added the cla:yes label Oct 31, 2024
@gshank gshank changed the title Support --empty options for 'snapshot' command Support --empty option for 'snapshot' command Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (8c6bec4) to head (ef57217).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10962      +/-   ##
==========================================
- Coverage   89.15%   89.08%   -0.07%     
==========================================
  Files         183      183              
  Lines       23529    23553      +24     
==========================================
+ Hits        20977    20983       +6     
- Misses       2552     2570      +18     
Flag Coverage Δ
integration 86.38% <100.00%> (-0.15%) ⬇️
unit 62.76% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.76% <100.00%> (+0.49%) ⬆️
Integration Tests 86.38% <100.00%> (-0.15%) ⬇️

@gshank gshank added the user docs [docs.getdbt.com] Needs better documentation label Nov 1, 2024
@gshank gshank merged commit bdf28d7 into main Nov 1, 2024
71 of 72 checks passed
@gshank gshank deleted the snapshot_empty branch November 1, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support --empty flag for snapshots
2 participants