Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore dev-requirements for dbt-adapters@main #10930

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Oct 28, 2024

Resolves #N/A

Problem

A pin on dbt-adapters was accidentally left in dev-requirements: accidentally left in a pin in dev-requirements

Example failure: #10929

Solution

restore dbt-adapters@main dependency

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

Sorry, something went wrong.

@MichelleArk MichelleArk requested a review from a team as a code owner October 28, 2024 21:38
@cla-bot cla-bot bot added the cla:yes label Oct 28, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (316ecfc) to head (dea5070).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10930   +/-   ##
=======================================
  Coverage   89.19%   89.19%           
=======================================
  Files         183      183           
  Lines       23466    23476   +10     
=======================================
+ Hits        20930    20940   +10     
  Misses       2536     2536           
Flag Coverage Δ
integration 86.56% <ø> (+<0.01%) ⬆️
unit 62.08% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.08% <68.18%> (+0.02%) ⬆️
Integration Tests 86.56% <100.00%> (+<0.01%) ⬆️

@MichelleArk MichelleArk merged commit 3224589 into main Oct 28, 2024
70 of 72 checks passed
@MichelleArk MichelleArk deleted the restore-dev-requirements-adapters branch October 28, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants