Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update adapter version messages #10919

Merged
merged 4 commits into from
Dec 11, 2024
Merged

update adapter version messages #10919

merged 4 commits into from
Dec 11, 2024

Conversation

dave-connors-3
Copy link
Contributor

Resolves #10230

Problem

The messages in dbt --version don't reflect the fact that the minor version of an adapter could be ahead of the minor version of dbt core

Solution

update the semver check in version.py!

I added the assertions for mypy's sake, but can be convinced to do that a different way

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@dave-connors-3 dave-connors-3 requested a review from a team as a code owner October 25, 2024 15:45
@cla-bot cla-bot bot added the cla:yes label Oct 25, 2024
@github-actions github-actions bot added the community This PR is from a community member label Oct 25, 2024
@dave-connors-3 dave-connors-3 changed the title update tests for mismatching plugins update adapter version messages Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (316ecfc) to head (894b114).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10919      +/-   ##
==========================================
- Coverage   89.19%   89.11%   -0.08%     
==========================================
  Files         183      183              
  Lines       23466    23779     +313     
==========================================
+ Hits        20930    21191     +261     
- Misses       2536     2588      +52     
Flag Coverage Δ
integration 86.43% <100.00%> (-0.13%) ⬇️
unit 62.16% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.16% <100.00%> (+0.10%) ⬆️
Integration Tests 86.43% <100.00%> (-0.13%) ⬇️

@graciegoheen graciegoheen added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Nov 12, 2024
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually just rip this version checking logic out 🤔

core/dbt/version.py Outdated Show resolved Hide resolved
@MichelleArk MichelleArk requested a review from QMalcolm December 5, 2024 00:11
@MichelleArk MichelleArk merged commit 6621015 into main Dec 11, 2024
54 of 55 checks passed
@MichelleArk MichelleArk deleted the dc/update-adapter-messages branch December 11, 2024 15:56
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.9.latest cla:yes community This PR is from a community member ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dbt -v doesn't know that adapters are decoupled from core
5 participants