-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update adapter version messages #10919
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10919 +/- ##
==========================================
- Coverage 89.19% 89.11% -0.08%
==========================================
Files 183 183
Lines 23466 23779 +313
==========================================
+ Hits 20930 21191 +261
- Misses 2536 2588 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually just rip this version checking logic out 🤔
(cherry picked from commit 6621015)
Resolves #10230
Problem
The messages in
dbt --version
don't reflect the fact that the minor version of an adapter could be ahead of the minor version of dbt coreSolution
update the semver check in
version.py
!I added the assertions for mypy's sake, but can be convinced to do that a different way
Checklist