Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and title for schemas.getdbt.com changes #10719

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 16, 2024

We should not require changes to schemas.getdbt.com prior to merging the core base pull request. That results in unresolvable merge conflicts and invalid schemas. A pull request in schemas.getdbt.com can be created, but it should not be merged until after the base pull request.

@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label Sep 16, 2024
@cla-bot cla-bot bot added the cla:yes label Sep 16, 2024
@gshank gshank requested a review from a team as a code owner September 16, 2024 14:53
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (6c111f2) to head (5716777).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10719      +/-   ##
==========================================
- Coverage   88.92%   88.87%   -0.05%     
==========================================
  Files         180      180              
  Lines       22847    22847              
==========================================
- Hits        20317    20306      -11     
- Misses       2530     2541      +11     
Flag Coverage Δ
integration 86.08% <ø> (-0.05%) ⬇️
unit 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <ø> (ø)
Integration Tests 86.08% <ø> (-0.05%) ⬇️

@gshank gshank merged commit aeaaedc into main Sep 16, 2024
65 checks passed
@gshank gshank deleted the schema_changes_post_merge branch September 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants