Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #10471 unused add_ephemeral_model_prefix #10577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: #10471 unused add_ephemeral_model_prefix #10577

wants to merge 1 commit into from

Conversation

donjin-master
Copy link
Contributor

Resolves #10471

Problem
This method appears to be unused across dbt-core, dbt-common, and dbt-adapters:

Solution
Removed the method add_ephemeral_model_prefix
Replaced this method with

def add_ephemeral_prefix(name: str):
return f"dbt__cte{name}"

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • I have signed the CLA

@donjin-master donjin-master requested a review from a team as a code owner August 16, 2024 08:33
@cla-bot cla-bot bot added the cla:yes label Aug 16, 2024
@github-actions github-actions bot added the community This PR is from a community member label Aug 16, 2024
@donjin-master donjin-master mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes community This PR is from a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused add_ephemeral_model_prefix method
1 participant
@donjin-master