Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update adapter hyperlink and comments about the decoupled architectur… #10458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdmcolorz
Copy link

@rdmcolorz rdmcolorz commented Jul 17, 2024

…e for post-decoupling

resolves #10386

Problem

[code docs] update ARCHITECTURE.md to reflect changes post-decoupling #10386

Solution

Add hyperlink to the dbt-adapters repo, add comment about the decoupling architecture.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@rdmcolorz rdmcolorz requested a review from a team as a code owner July 17, 2024 02:06
Copy link

cla-bot bot commented Jul 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Taylor Yang.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the community This PR is from a community member label Jul 17, 2024
Copy link

cla-bot bot commented Jul 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Taylor Yang.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@rdmcolorz rdmcolorz force-pushed the bugfix/update-code-docs-changes-post-decoupling branch from 5af5ed8 to 5c89eb7 Compare July 17, 2024 06:57
@cla-bot cla-bot bot added the cla:yes label Jul 17, 2024
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member stale Issues that have gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[code docs] update ARCHITECTURE.md to reflect changes post-decoupling
1 participant