Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy first] generate protos w protoc version 5.26.1 #10456

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 17, 2024

resolves #10457

Problem

Currently types_pb2.py is generated using protoc version 4.25.3. It looks like the latest compatible version of protoc that doesn't need any code changes (indicated by failing tests is 5.26.1).

Solution

generate core_types_pb2.py with protoc version 5.26.1

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@MichelleArk MichelleArk requested a review from a team as a code owner July 17, 2024 00:53
@cla-bot cla-bot bot added the cla:yes label Jul 17, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.76%. Comparing base (4c7d922) to head (d4aa2e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10456   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         180      180           
  Lines       22564    22564           
=======================================
  Hits        20029    20029           
  Misses       2535     2535           
Flag Coverage Δ
integration 86.03% <12.50%> (ø)
unit 62.10% <12.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.10% <12.50%> (ø)
Integration Tests 86.03% <12.50%> (ø)

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichelleArk MichelleArk merged commit 2a26fab into main Jul 17, 2024
64 of 66 checks passed
@MichelleArk MichelleArk deleted the bump-protoc-version branch July 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use protoc 5.26.1 to generate core_types_pb2.py
2 participants