Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test__model_contract_true #10449

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 16, 2024

resolves #N/A

Problem

Seeing surprising failures in dbt-core locally after a dbt-common merge to main I just did.

Solution

The dbt-common change itself should be back-compat and so this should be a matter of updating tests. common merge queue did not catch it because of dbt-labs/dbt-common#104

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Jul 16, 2024
@MichelleArk MichelleArk requested a review from a team as a code owner July 16, 2024 15:02
@cla-bot cla-bot bot added the cla:yes label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (a7af3b3) to head (a17a819).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10449   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         180      180           
  Lines       22562    22562           
=======================================
  Hits        20038    20038           
  Misses       2524     2524           
Flag Coverage Δ
integration 86.16% <ø> (+<0.01%) ⬆️
unit 62.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.10% <ø> (ø)
Integration Tests 86.16% <ø> (+<0.01%) ⬆️

@MichelleArk MichelleArk force-pushed the fix-tests-contract-configs branch from b40d9d5 to a17a819 Compare July 16, 2024 15:15
@MichelleArk MichelleArk requested review from aranke and emmyoop July 16, 2024 15:29
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichelleArk MichelleArk merged commit b032915 into main Jul 16, 2024
63 checks passed
@MichelleArk MichelleArk deleted the fix-tests-contract-configs branch July 16, 2024 15:32
github-actions bot pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants