Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover additional listagg cases #10445

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

igorvoltaic
Copy link
Contributor

@igorvoltaic igorvoltaic commented Jul 14, 2024

resolves #10444

Problem

listagg marco does not cover all possible cases described in the docs

Solution

add more test cases

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@igorvoltaic igorvoltaic requested a review from a team as a code owner July 14, 2024 03:47
Copy link

cla-bot bot commented Jul 14, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @igorvoltaic

@github-actions github-actions bot added the community This PR is from a community member label Jul 14, 2024
@igorvoltaic
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Jul 14, 2024
Copy link

cla-bot bot commented Jul 14, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (33161a3) to head (24647d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10445      +/-   ##
==========================================
- Coverage   88.82%   88.77%   -0.05%     
==========================================
  Files         180      180              
  Lines       22584    22584              
==========================================
- Hits        20060    20049      -11     
- Misses       2524     2535      +11     
Flag Coverage Δ
integration 85.99% <ø> (-0.13%) ⬇️
unit 62.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.15% <ø> (ø)
Integration Tests 85.99% <ø> (-0.13%) ⬇️

@dbeatty10 dbeatty10 changed the title test: cover addidtional listagg cases test: cover additional listagg cases Jul 15, 2024
@peterallenwebb peterallenwebb merged commit c4958de into dbt-labs:main Jul 18, 2024
56 of 57 checks passed
@peterallenwebb
Copy link
Contributor

@igorvoltaic Thank you for making dbt better!

@dbeatty10
Copy link
Contributor

There could be adapters with a buggy implementation of listagg, and their CI could start breaking as a result if they inherit this test.

In that case, they'd need to do one of the following:

  1. update their implementation to cover the edge case (recommended)
  2. update their test definition to exclude those test cases (not recommended)
  3. skip the test entirely (not recommended)

@igorvoltaic igorvoltaic deleted the update-listagg-tests branch July 18, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add more test cases for listagg macro
3 participants