-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cover additional listagg cases #10445
test: cover additional listagg cases #10445
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @igorvoltaic |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10445 +/- ##
==========================================
- Coverage 88.82% 88.77% -0.05%
==========================================
Files 180 180
Lines 22584 22584
==========================================
- Hits 20060 20049 -11
- Misses 2524 2535 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@igorvoltaic Thank you for making dbt better! |
There could be adapters with a buggy implementation of In that case, they'd need to do one of the following:
|
resolves #10444
Problem
listagg marco does not cover all possible cases described in the docs
Solution
add more test cases
Checklist