Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing for artifact schemas #10443

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

nakamichiworks
Copy link
Contributor

resolves #10442

Problem

Types of artifact schemas decorated with @schema_version() are incorrectly inferred to be VersionedSchema.

Solution

Fixes a type hint in schema_version() function.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@nakamichiworks nakamichiworks requested a review from a team as a code owner July 14, 2024 00:49
Copy link

cla-bot bot commented Jul 14, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @nakamichiworks

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Jul 14, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 14, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (6e4564a) to head (411c4e9).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10443      +/-   ##
==========================================
- Coverage   88.81%   88.80%   -0.02%     
==========================================
  Files         180      180              
  Lines       22573    22574       +1     
==========================================
- Hits        20049    20046       -3     
- Misses       2524     2528       +4     
Flag Coverage Δ
integration 86.07% <100.00%> (-0.12%) ⬇️
unit 62.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.18% <100.00%> (+<0.01%) ⬆️
Integration Tests 86.07% <100.00%> (-0.12%) ⬇️

@MichelleArk MichelleArk added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Jul 24, 2024
@MichelleArk MichelleArk merged commit e1621eb into dbt-labs:main Jul 24, 2024
65 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Artifact schemas are inferred to be incorrect types
2 participants