-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify snapshot config to allow using schema/database/alias macros #10439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10439 +/- ##
==========================================
- Coverage 88.79% 88.79% -0.01%
==========================================
Files 180 180
Lines 22562 22549 -13
==========================================
- Hits 20034 20022 -12
+ Misses 2528 2527 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gshank
added
the
artifact_minor_upgrade
To bypass the CI check by confirming that the change is not breaking
label
Jul 13, 2024
gshank
changed the title
Tweak snapshot config to allow using schema/database/alias macros
Modify snapshot config to allow using schema/database/alias macros
Jul 15, 2024
peterallenwebb
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
artifact_minor_upgrade
To bypass the CI check by confirming that the change is not breaking
cla:yes
user docs
[docs.getdbt.com] Needs better documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10301
Problem
Snapshots are special snowflakes and use "target_schema" and "target_database" instead of standard schema/database/alias.
Solution
Do not require setting "target_schema" and instead use standard schema setting (unless target_schema or target_database is set, then override).
Checklist