-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #10422: add test for env_var casing on windows #10436
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10436 +/- ##
==========================================
+ Coverage 88.76% 88.82% +0.05%
==========================================
Files 180 180
Lines 22564 22564
==========================================
+ Hits 20029 20042 +13
+ Misses 2535 2522 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
Resolves #10422
Problem
dbt-core
1.8+ is treating env-vars are case-sensitive on Windows, even though Windows env-vars are not case-sensitive.dbt-core
1.7, since the test I wrote passes with 1.6.Solution
Checklist