Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified git tag option in dbt deps #10398

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Jul 3, 2024

resolves #10381

Problem

in option git config --local column.ui always, dbt deps failed to install packages.
details on link

Solution

Use git tag --no-column instead of git tag --list to prevent the issue described in #10305

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.15%. Comparing base (37e2725) to head (1358f69).
Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10398      +/-   ##
==========================================
+ Coverage   88.82%   89.15%   +0.33%     
==========================================
  Files         180      183       +3     
  Lines       22526    23443     +917     
==========================================
+ Hits        20009    20901     +892     
- Misses       2517     2542      +25     
Flag Coverage Δ
integration 86.43% <100.00%> (+0.25%) ⬆️
unit 62.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.13% <100.00%> (+0.01%) ⬆️
Integration Tests 86.43% <100.00%> (+0.25%) ⬆️

@jx2lee jx2lee force-pushed the fix-deps-gitcmd branch from 46abc2d to 2a492c7 Compare July 20, 2024 05:34
@jx2lee jx2lee marked this pull request as ready for review July 20, 2024 15:17
@jx2lee jx2lee requested a review from a team as a code owner July 20, 2024 15:17
@github-actions github-actions bot added the community This PR is from a community member label Jul 20, 2024
@jx2lee
Copy link
Contributor Author

jx2lee commented Oct 22, 2024

I've written unit test code. anyone review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use git tag --no-column for listing tags for dbt deps
1 participant