Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing DSI tests #10392

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Skip failing DSI tests #10392

merged 1 commit into from
Jul 2, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 2, 2024

Would be resolved by #10349

Problem

After another DSI release we have 2 failing tests.

Solution

Skip them until the tests can be reworked.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jul 2, 2024
@emmyoop emmyoop requested a review from a team as a code owner July 2, 2024 13:47
@cla-bot cla-bot bot added the cla:yes label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (a94027a) to head (91161dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10392      +/-   ##
==========================================
- Coverage   88.83%   88.77%   -0.07%     
==========================================
  Files         180      180              
  Lines       22526    22526              
==========================================
- Hits        20012    19998      -14     
- Misses       2514     2528      +14     
Flag Coverage Δ
integration 86.04% <ø> (-0.14%) ⬇️
unit 62.11% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.11% <ø> (-0.02%) ⬇️
Integration Tests 86.04% <ø> (-0.14%) ⬇️

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit 37fd299 into main Jul 2, 2024
68 of 69 checks passed
@emmyoop emmyoop deleted the er/fix-dsi-tests branch July 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants