Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy first] Add some mypy types to parser files #10380

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jun 28, 2024

Tidy first pull request to do some mypy cleanup in the parser.

@gshank gshank added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Jun 28, 2024
@gshank gshank requested a review from a team as a code owner June 28, 2024 19:53
@cla-bot cla-bot bot added the cla:yes label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.51%. Comparing base (c215697) to head (5f65b1f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10380      +/-   ##
==========================================
- Coverage   88.81%   87.51%   -1.31%     
==========================================
  Files         180      180              
  Lines       22496    22515      +19     
==========================================
- Hits        19980    19704     -276     
- Misses       2516     2811     +295     
Flag Coverage Δ
integration 84.52% <93.75%> (-1.65%) ⬇️
unit 62.14% <71.87%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.14% <71.87%> (-0.02%) ⬇️
Integration Tests 84.52% <93.75%> (-1.65%) ⬇️

@gshank gshank merged commit 4ea0e10 into main Jul 8, 2024
63 of 66 checks passed
@gshank gshank deleted the some_mypy_parser_types branch July 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants