-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental models with a contract don't need their columns modified #10371
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10371 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 180 180
Lines 22704 22704
=======================================
Hits 20169 20169
Misses 2535 2535
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, conditional on reverting the feature branch reference in dev-requirements.txt
.
dev-requirements.txt
Outdated
@@ -1,4 +1,4 @@ | |||
git+https://github.com/dbt-labs/dbt-adapters.git@main | |||
git+https://github.com/dbt-labs/dbt-adapters.git@incremental_contract_varchar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to revert this prior to merging.
resolves #10362
Problem
Incremental models with existing tables had their columns updated by "expand_target_column_types", but this is unnecessary when models have a contract.
Solution
Do not call "expand_target_column_types" when an incremental model has an enforced contract.
Checklist