Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make time spine model name a constant #10363

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

aliceliu
Copy link
Contributor

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jun 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aliceliu and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (11ee2b9) to head (564df42).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10363   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files         180      180           
  Lines       22486    22487    +1     
=======================================
+ Hits        19957    19958    +1     
  Misses       2529     2529           
Flag Coverage Δ
integration 86.01% <100.00%> (+<0.01%) ⬆️
unit 62.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.19% <100.00%> (+<0.01%) ⬆️
Integration Tests 86.01% <100.00%> (+<0.01%) ⬆️

@ChenyuLInx ChenyuLInx added the Skip Changelog Skips GHA to check for changelog file label Jun 25, 2024
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@aliceliu aliceliu marked this pull request as ready for review June 25, 2024 22:24
@aliceliu aliceliu requested a review from a team as a code owner June 25, 2024 22:24
@github-actions github-actions bot added the community This PR is from a community member label Jun 25, 2024
@ChenyuLInx ChenyuLInx merged commit d936a63 into main Jun 25, 2024
77 of 79 checks passed
@ChenyuLInx ChenyuLInx deleted the 06-25-make_time_spine_model_name_a_constant branch June 25, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants