Mark test_metric_type_params_satisfies_protocol test as skipped

[emmyoop]

Problem

Tests in tests/unit/test_semantic_layer_nodes_satisfy_protocols.py are a safety check. They mean that in some way, core is not satisfying the protocols that DSI provides. Unfortunately it's a bit harder to write a test to identify whether the failure to satisfy the protocol is breaking or not. Looking at this failure, it seems that we are not providing an optional key/value which is okay (not breaking).

Solution

Mark the failing test as skipped until we can come up with a more stable approach for these tests to not fail when the protocol doesn't match optional fields.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (9a796aa) to head (dd578bf).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10348      +/-   ##
==========================================
+ Coverage   86.01%   88.75%   +2.73%     
==========================================
  Files         180      180              
  Lines       22486    22486              
==========================================
+ Hits        19341    19957     +616     
+ Misses       3145     2529     -616     

Flag	Coverage Δ
integration	86.01% <ø> (ø)
unit	62.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.