Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Graph class #10338

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Conversation

QMalcolm
Copy link
Contributor

resolves #9871

Problem

We haven't been directly unit testing our Graph class, which is an integral class to the operation of dbt

Solution

Add unit tests

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@QMalcolm QMalcolm requested a review from a team as a code owner June 18, 2024 23:00
@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Jun 18, 2024
@cla-bot cla-bot bot added the cla:yes label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (100352d) to head (259036e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10338      +/-   ##
==========================================
+ Coverage   88.71%   88.78%   +0.06%     
==========================================
  Files         180      180              
  Lines       22483    22490       +7     
==========================================
+ Hits        19946    19967      +21     
+ Misses       2537     2523      -14     
Flag Coverage Δ
integration 86.04% <ø> (+0.06%) ⬆️
unit 62.22% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm QMalcolm merged commit 9a796aa into main Jun 20, 2024
66 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--9871-tests-for-digraph branch June 20, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DiGraph fixtured and unit test Graph Class
2 participants