Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.7.latest] Add most recent dbt-docs changes #10335

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 18, 2024

Backport 8ee8b25 from #10307.

@cla-bot cla-bot bot added the cla:yes label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (d96a927) to head (2c2c145).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.7.latest   #10335      +/-   ##
==============================================
- Coverage       86.74%   86.71%   -0.03%     
==============================================
  Files             179      179              
  Lines           26724    26724              
==============================================
- Hits            23183    23175       -8     
- Misses           3541     3549       +8     
Flag Coverage Δ
integration 83.59% <ø> (-0.07%) ⬇️
unit 65.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review June 19, 2024 12:46
@aranke aranke requested a review from a team as a code owner June 19, 2024 12:46
@MichelleArk
Copy link
Contributor

MichelleArk commented Jun 20, 2024

Was able to tophat this locally with postgres 🎩 (be extra careful setting up a fresh environment here (no dbt-adapters or dbt-common)

~/src/dbt-core backport-10307-to-1.7.latest ❯❯ git checkout backport-10307-to-1.7.latest
Switched to branch 'backport-10307-to-1.7.latest'
Your branch is up to date with 'origin/backport-10307-to-1.7.latest'.

❯ cd ../jaffle-shop

~/src/jaffle-shop main* ❯❯ dbt --version
Core:
  - installed: 1.7.16
  - latest:    1.8.2  - Update available!

  Your version of dbt-core is out of date!
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

Plugins:


~/src/jaffle-shop main* ❯❯ dbt docs generate
15:39:01  Running with dbt=1.7.16
15:39:01  target not specified in profile 'postgres', using 'default'
15:39:01  Registered adapter: postgres=1.7.16
15:39:01  Unable to do partial parsing because of a version mismatch
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:03  Found 18 models, 6 seeds, 20 tests, 6 sources, 0 exposures, 13 metrics, 699 macros, 0 groups, 6 semantic models
15:39:03
15:39:03  Concurrency: 1 threads (target='default')
15:39:03
15:39:03  Building catalog
15:39:03  Catalog written to /Users/michelleark/src/jaffle-shop/target/catalog.json

~/src/jaffle-shop main* ❯❯ dbt docs serve
15:39:07  Running with dbt=1.7.16
15:39:07  target not specified in profile 'postgres', using 'default'
Serving docs at 8080
To access from your browser, navigate to: http://localhost:8080



Press Ctrl+C to exit.
127.0.0.1 - - [20/Jun/2024 11:39:07] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [20/Jun/2024 11:39:07] "GET /manifest.json?cb=1718897947801 HTTP/1.1" 200 -
127.0.0.1 - - [20/Jun/2024 11:39:07] "GET /catalog.json?cb=1718897947801 HTTP/1.1" 200 -

poked around the UI, no warnings / errors + link to graph viz screenshot:
Screenshot 2024-06-20 at 11 39 17 AM

@MichelleArk MichelleArk merged commit 0593c0b into 1.7.latest Jun 20, 2024
119 checks passed
@MichelleArk MichelleArk deleted the backport-10307-to-1.7.latest branch June 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants