Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update on_skip to adjust for node that do not have schema #10302

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

ChenyuLInx
Copy link
Contributor

resolves #10029

Problem

SavedQuery node do not have schema field, this cause on_skip to fail.

Solution

During the on skip, we optionally get schema field.
The other way is to add schema to the saved_query node, but that is not a useful piece of information for this node.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner June 12, 2024 19:42
@cla-bot cla-bot bot added the cla:yes label Jun 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

num_nodes=None,
)
# on_skip would work
runner.on_skip()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would fail without change above

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (e699f5d) to head (d303bee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10302   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files         180      180           
  Lines       22483    22483           
=======================================
  Hits        19942    19942           
  Misses       2541     2541           
Flag Coverage Δ
integration 85.95% <100.00%> (ø)
unit 61.78% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChenyuLInx ChenyuLInx merged commit 8639290 into main Jun 12, 2024
63 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/fix-10029 branch June 12, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Skip SavedQuery node would cause dbt-core to error out on the node
2 participants