Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot config to work in yaml files #10275

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jun 7, 2024

resolves #4000

Problem

Validation that all required keys exist was being done when the snapshot sql file was being created, so it was not possible to define the config in a yaml file.

Solution

Delay part of the validation until the end of parsing.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@gshank gshank requested a review from a team as a code owner June 7, 2024 17:49
@cla-bot cla-bot bot added the cla:yes label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (b680c7a) to head (c8ab084).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10275      +/-   ##
==========================================
- Coverage   88.73%   87.94%   -0.79%     
==========================================
  Files         180      180              
  Lines       22474    22495      +21     
==========================================
- Hits        19942    19783     -159     
- Misses       2532     2712     +180     
Flag Coverage Δ
integration 84.55% <100.00%> (-1.54%) ⬇️
unit 63.21% <70.58%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Jun 7, 2024
@gshank gshank merged commit 4df120e into main Jun 7, 2024
66 of 68 checks passed
@gshank gshank deleted the snapshot_schema_config branch June 7, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot config doesn't work in schema.yml
2 participants