test adapter pre hooks for unit testing #10273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mcknight/10198 #10273 +/- ##
==================================================
- Coverage 88.69% 88.67% -0.02%
==================================================
Files 180 180
Lines 22520 22479 -41
==================================================
- Hits 19973 19934 -39
+ Misses 2547 2545 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
commented
Jun 7, 2024
| mock_pre_model_hook = mock.Mock() | ||
| mock_pre_model_hook.side_effect = CompilationError("exception from adapter.pre_model_hook") | ||
| with mock.patch.object(type(project.adapter), "pre_model_hook", mock_pre_model_hook): | ||
| run_dbt(["test", "--select", "test_name:test_my_model"], expect_pass=False) |
There was a problem hiding this comment.
probably want to use capture_and_run_dbt here and inspect the logs instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Problem
Solution
Checklist