Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DIFF as a recording mode #10263

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Support DIFF as a recording mode #10263

merged 4 commits into from
Jun 20, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jun 5, 2024

part of dbt-labs/dbt-common#144

Problem

No support for new Diff mode in recording

Solution

Add DIFF support.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop force-pushed the er/diff-recording branch from c5291c3 to d00b84c Compare June 17, 2024 12:53
core/dbt/cli/requires.py Outdated Show resolved Hide resolved
@emmyoop
Copy link
Member Author

emmyoop commented Jun 18, 2024

Tests will fail until dbt-labs/dbt-common#149 is merged and released

@emmyoop emmyoop closed this Jun 18, 2024
@emmyoop emmyoop reopened this Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.02%. Comparing base (100352d) to head (94cee97).
Report is 7 commits behind head on main.

Files Patch % Lines
core/dbt/cli/requires.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10263      +/-   ##
==========================================
+ Coverage   88.71%   89.02%   +0.31%     
==========================================
  Files         180      180              
  Lines       22483    23108     +625     
==========================================
+ Hits        19946    20573     +627     
+ Misses       2537     2535       -2     
Flag Coverage Δ
integration 86.42% <10.00%> (+0.45%) ⬆️
unit 62.92% <10.00%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jun 18, 2024
@emmyoop emmyoop marked this pull request as ready for review June 18, 2024 18:09
@emmyoop emmyoop requested a review from a team as a code owner June 18, 2024 18:09
@emmyoop emmyoop closed this Jun 18, 2024
@emmyoop emmyoop reopened this Jun 18, 2024
@emmyoop emmyoop closed this Jun 20, 2024
@emmyoop emmyoop reopened this Jun 20, 2024
@emmyoop emmyoop merged commit 51ff85b into main Jun 20, 2024
175 of 232 checks passed
@emmyoop emmyoop deleted the er/diff-recording branch June 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants