Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CatalogKey, ColumnMetadata, ColumnMap, CatalogTable to dbt-common #10253

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 3, 2024

Problem

Part 2 of dbt-labs/dbt-common#147, we want to move CatalogTable to dbt-common, so adapters can depend on them

Solution

Keep import stubs via __init__.py, but depend on versions from dbt-common.
Will require a dbt-common minor version bump.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke added Skip Changelog Skips GHA to check for changelog file artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Jun 3, 2024
@aranke aranke marked this pull request as ready for review June 10, 2024 14:49
@aranke aranke requested a review from a team as a code owner June 10, 2024 14:50
@aranke aranke requested a review from MichelleArk June 10, 2024 14:50
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (bff116d) to head (bc9e16f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10253      +/-   ##
==========================================
- Coverage   88.72%   88.66%   -0.06%     
==========================================
  Files         180      180              
  Lines       22495    22478      -17     
==========================================
- Hits        19959    19931      -28     
- Misses       2536     2547      +11     
Flag Coverage Δ
integration 85.92% <100.00%> (-0.14%) ⬇️
unit 61.70% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk
Copy link
Contributor

Keep import stubs via init.py, but depend on versions from dbt-common.
👍

@aranke aranke merged commit e977b3e into main Jun 11, 2024
63 checks passed
@aranke aranke deleted the catalogtable_dbt_common branch June 11, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants