Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to open an issue for the docs.getdbt.com documentation repo #10239

Merged
merged 1 commit into from
May 30, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented May 29, 2024

Per suggestion in dbt-labs/docs.getdbt.com#5577 (comment)

Problem

On the new issue template page https://github.com/dbt-labs/dbt-core/issues/new/choose, there is no documentation category, so users may not know that https://github.com/dbt-labs/docs.getdbt.com/issues/new/choose is the place.

Solution

When choosing the type of issue to open, add a button that links to https://github.com/dbt-labs/docs.getdbt.com/issues/new/choose

🎩

Screenshot taken after merge (since I didn't know of any way to preview it beforehand):

image

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • Tests are not required/relevant for this PR
  • This PR has already received feedback and approval from Product or DX

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label May 29, 2024
@cla-bot cla-bot bot added the cla:yes label May 29, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review May 29, 2024 14:08
@dbeatty10 dbeatty10 requested a review from a team as a code owner May 29, 2024 14:08
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (3e37d77) to head (dd7cf33).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10239      +/-   ##
==========================================
- Coverage   88.72%   88.67%   -0.05%     
==========================================
  Files         180      180              
  Lines       22476    22476              
==========================================
- Hits        19942    19931      -11     
- Misses       2534     2545      +11     
Flag Coverage Δ
integration 85.93% <ø> (-0.14%) ⬇️
unit 63.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@iamtodor iamtodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@dbeatty10 dbeatty10 merged commit 1554828 into main May 30, 2024
67 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty10-patch-1 branch May 30, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants