Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move StatsItem, StatsDict, TableMetadata to dbt-common #10238

Merged
merged 14 commits into from
May 30, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented May 29, 2024

Problem

Part 2 of dbt-labs/dbt-common#141, we want to move the catalog artifact schema to dbt-common so adapters can depend on them

Solution

Keep import stubs via __init__.py, but depend on versions from dbt-common.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label May 29, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke changed the title Move catalog artifact schema to dbt_common Move StatsItem, StatsDict, TableMetadata to dbt-common May 29, 2024
@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label May 29, 2024
@aranke aranke added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (d8e38c1) to head (b47b3be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10238      +/-   ##
==========================================
+ Coverage   88.65%   88.71%   +0.05%     
==========================================
  Files         180      180              
  Lines       22477    22463      -14     
==========================================
+ Hits        19928    19929       +1     
+ Misses       2549     2534      -15     
Flag Coverage Δ
integration 86.03% <100.00%> (+0.12%) ⬆️
unit 63.27% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review May 29, 2024 20:22
@aranke aranke requested a review from a team as a code owner May 29, 2024 20:22
@aranke aranke requested a review from MichelleArk May 29, 2024 20:22
@aranke aranke merged commit 81386a7 into main May 30, 2024
69 of 70 checks passed
@aranke aranke deleted the catalog_schema_dbt_common branch May 30, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants