Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Renaming or removing a contracted model raises a BreakingChange warning/error #10221

Merged
merged 5 commits into from
May 28, 2024

extend state:modified deletion handling to removed (including disabling)

e10efff
Select commit
Loading
Failed to load commit list.
Merged

[Fix] Renaming or removing a contracted model raises a BreakingChange warning/error #10221

extend state:modified deletion handling to removed (including disabling)
e10efff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 28, 2024 in 0s

88.67% (-0.01%) compared to 366d4ad

View this Pull Request on Codecov

88.67% (-0.01%) compared to 366d4ad

Details

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.67%. Comparing base (366d4ad) to head (e10efff).
Report is 4 commits behind head on main.

Files Patch % Lines
core/dbt/contracts/graph/nodes.py 94.11% 1 Missing ⚠️
core/dbt/parser/manifest.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10221      +/-   ##
==========================================
- Coverage   88.68%   88.67%   -0.01%     
==========================================
  Files         180      180              
  Lines       22435    22476      +41     
==========================================
+ Hits        19896    19931      +35     
- Misses       2539     2545       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.