-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change port bind and add a unittest #10208
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10208 +/- ##
==========================================
+ Coverage 88.59% 88.68% +0.08%
==========================================
Files 180 180
Lines 22435 22435
==========================================
+ Hits 19876 19896 +20
+ Misses 2559 2539 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 0c08d7a)
(cherry picked from commit 0c08d7a)
(cherry picked from commit 0c08d7a)
* change port bind and add a unittest (#10208) (cherry picked from commit 0c08d7a) * fix unit tests * remove ssh-key since schemas repo is public * fix compare schemas diff --------- Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Michelle Ark <[email protected]>
* change port bind and add a unittest (#10208) (cherry picked from commit 0c08d7a) * fix unit tests * remove ssh-key since schemas repo is public * fix compare schemas diff --------- Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Michelle Ark <[email protected]>
@MichelleArk While I understand the sanity of having 127.0.0.1 as the default bind address, this broke our k8s deployment because the readiness check cannot pass and I cannot override the bind address because it's hard coded. Can we add a cli/env flag to override this? |
Ach, sorry about that! I think an override sounds completely reasonable here, perhaps something like cc @jtcohen6 |
Makes sense to me! We already support
|
resolves #10209
Problem
Solution
Checklist