Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change port bind and add a unittest #10208

Merged
merged 4 commits into from
May 22, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented May 22, 2024

resolves #10209

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label May 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (eb71ad9) to head (00b1211).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10208      +/-   ##
==========================================
+ Coverage   88.59%   88.68%   +0.08%     
==========================================
  Files         180      180              
  Lines       22435    22435              
==========================================
+ Hits        19876    19896      +20     
+ Misses       2559     2539      -20     
Flag Coverage Δ
integration 85.95% <0.00%> (ø)
unit 63.27% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk marked this pull request as ready for review May 22, 2024 02:29
@MichelleArk MichelleArk requested a review from a team as a code owner May 22, 2024 02:29
@MichelleArk MichelleArk requested a review from emmyoop May 22, 2024 13:49
@MichelleArk MichelleArk merged commit 0c08d7a into main May 22, 2024
63 checks passed
@MichelleArk MichelleArk deleted the explicit-localhost-bind-docs-serve branch May 22, 2024 14:00
github-actions bot pushed a commit that referenced this pull request May 22, 2024
github-actions bot pushed a commit that referenced this pull request May 22, 2024
github-actions bot pushed a commit that referenced this pull request May 22, 2024
gshank pushed a commit that referenced this pull request May 22, 2024
* change port bind and add a unittest (#10208)

(cherry picked from commit 0c08d7a)

* fix unit tests

* remove ssh-key since schemas repo is public

* fix compare schemas diff

---------

Co-authored-by: Michelle Ark <[email protected]>
Co-authored-by: Michelle Ark <[email protected]>
gshank pushed a commit that referenced this pull request May 22, 2024
* change port bind and add a unittest (#10208)

(cherry picked from commit 0c08d7a)

* fix unit tests

* remove ssh-key since schemas repo is public

* fix compare schemas diff

---------

Co-authored-by: Michelle Ark <[email protected]>
Co-authored-by: Michelle Ark <[email protected]>
@macnibblet
Copy link

@MichelleArk While I understand the sanity of having 127.0.0.1 as the default bind address, this broke our k8s deployment because the readiness check cannot pass and I cannot override the bind address because it's hard coded.

Can we add a cli/env flag to override this?

@MichelleArk
Copy link
Contributor Author

Ach, sorry about that! I think an override sounds completely reasonable here, perhaps something like dbt docs serve --host.

cc @jtcohen6

@jtcohen6
Copy link
Contributor

Makes sense to me! We already support --port, so it makes sense to support --host as well, with 127.0.0.1 as the default:

$ dbt docs serve --host 127.0.01 --port 8080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly bind to localhost in docs serve
5 participants