-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recording types #10175
add recording types #10175
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ea76a40
to
26a8b1f
Compare
Tests are failing because it needs the changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving for after the supporting dbt-common changes are in place and testing passes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10175 +/- ##
==========================================
+ Coverage 88.65% 88.73% +0.07%
==========================================
Files 180 180
Lines 22422 22477 +55
==========================================
+ Hits 19879 19945 +66
+ Misses 2543 2532 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
resolves #10240
Problem
Record operates as all or nothing.
Solution
Add option to record by types
Checklist