Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the "Explain It Like I'm 64" folder to "guides" #10141

Merged
merged 1 commit into from
May 14, 2024

Conversation

dbeatty10
Copy link
Contributor

resolves N/A

Problem

We have a folder with a placeholder name that is not intuitive: eli64

Solution

Standardize along with dbt-common and dbt-adapters on a better name: guides.

Checklist

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label May 14, 2024
@cla-bot cla-bot bot added the cla:yes label May 14, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review May 14, 2024 16:25
@dbeatty10 dbeatty10 requested a review from a team as a code owner May 14, 2024 16:25
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (751139d) to head (d8057ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10141      +/-   ##
==========================================
- Coverage   88.63%   88.61%   -0.02%     
==========================================
  Files         180      180              
  Lines       22422    22422              
==========================================
- Hits        19874    19870       -4     
- Misses       2548     2552       +4     
Flag Coverage Δ
integration 85.98% <ø> (-0.10%) ⬇️
unit 62.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better than my proposal of $$eli_(2^6)$$

@dbeatty10 dbeatty10 merged commit d21ff38 into main May 14, 2024
67 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty/docs-guides branch May 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants