improve semantic manifest error message #10128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9849
Problem
Improves this error message to provide more details as to what is wrong with the Semantic Manifest.
Solution
This PR moved the raising of an error to the validate() method and made it return
None
instead ofbool
.From what I checked, this behavior aligns with other validations in the project (example_1, example_2, example_3).
Before the fix:
After the fix:
Checklist